Skip to content

Commit

Permalink
jbd2: fix kernel-doc descriptions for jbd2_journal_shrink_{scan,count}()
Browse files Browse the repository at this point in the history
Add the description of @shrink and @sc in jbd2_journal_shrink_scan() and
jbd2_journal_shrink_count() kernel-doc comment to remove warnings found
by running scripts/kernel-doc, which is caused by using 'make W=1'.
fs/jbd2/journal.c:1296: warning: Function parameter or member 'shrink'
not described in 'jbd2_journal_shrink_scan'
fs/jbd2/journal.c:1296: warning: Function parameter or member 'sc' not
described in 'jbd2_journal_shrink_scan'
fs/jbd2/journal.c:1320: warning: Function parameter or member 'shrink'
not described in 'jbd2_journal_shrink_count'
fs/jbd2/journal.c:1320: warning: Function parameter or member 'sc' not
described in 'jbd2_journal_shrink_count'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220110132841.34531-1-yang.lee@linux.alibaba.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
  • Loading branch information
Yang Li authored and Theodore Ts'o committed Feb 3, 2022
1 parent 7c268d4 commit 715a67f
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions fs/jbd2/journal.c
Original file line number Diff line number Diff line change
Expand Up @@ -1287,6 +1287,8 @@ static int jbd2_min_tag_size(void)

/**
* jbd2_journal_shrink_scan()
* @shrink: shrinker to work on
* @sc: reclaim request to process
*
* Scan the checkpointed buffer on the checkpoint list and release the
* journal_head.
Expand All @@ -1312,6 +1314,8 @@ static unsigned long jbd2_journal_shrink_scan(struct shrinker *shrink,

/**
* jbd2_journal_shrink_count()
* @shrink: shrinker to work on
* @sc: reclaim request to process
*
* Count the number of checkpoint buffers on the checkpoint list.
*/
Expand Down

0 comments on commit 715a67f

Please sign in to comment.