Skip to content

Commit

Permalink
swiotlb: add debugfs to track swiotlb buffer usage
Browse files Browse the repository at this point in the history
The device driver will not be able to do dma operations once swiotlb buffer
is full, either because the driver is using so many IO TLB blocks inflight,
or because there is memory leak issue in device driver. To export the
swiotlb buffer usage via debugfs would help the user estimate the size of
swiotlb buffer to pre-allocate or analyze device driver memory leak issue.

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  • Loading branch information
Dongli Zhang authored and Konrad Rzeszutek Wilk committed Feb 12, 2019
1 parent 6442ca2 commit 71602fe
Showing 1 changed file with 44 additions and 0 deletions.
44 changes: 44 additions & 0 deletions kernel/dma/swiotlb.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@
#include <linux/scatterlist.h>
#include <linux/mem_encrypt.h>
#include <linux/set_memory.h>
#ifdef CONFIG_DEBUG_FS
#include <linux/debugfs.h>
#endif

#include <asm/io.h>
#include <asm/dma.h>
Expand Down Expand Up @@ -72,6 +75,11 @@ phys_addr_t io_tlb_start, io_tlb_end;
*/
static unsigned long io_tlb_nslabs;

/*
* The number of used IO TLB block
*/
static unsigned long io_tlb_used;

/*
* This is a free list describing the number of free entries available from
* each index
Expand Down Expand Up @@ -524,6 +532,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
dev_warn(hwdev, "swiotlb buffer is full (sz: %zd bytes)\n", size);
return DMA_MAPPING_ERROR;
found:
io_tlb_used += nslots;
spin_unlock_irqrestore(&io_tlb_lock, flags);

/*
Expand Down Expand Up @@ -584,6 +593,8 @@ void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr,
*/
for (i = index - 1; (OFFSET(i, IO_TLB_SEGSIZE) != IO_TLB_SEGSIZE -1) && io_tlb_list[i]; i--)
io_tlb_list[i] = ++count;

io_tlb_used -= nslots;
}
spin_unlock_irqrestore(&io_tlb_lock, flags);
}
Expand Down Expand Up @@ -662,3 +673,36 @@ swiotlb_dma_supported(struct device *hwdev, u64 mask)
{
return __phys_to_dma(hwdev, io_tlb_end - 1) <= mask;
}

#ifdef CONFIG_DEBUG_FS

static int __init swiotlb_create_debugfs(void)
{
static struct dentry *d_swiotlb_usage;
struct dentry *ent;

d_swiotlb_usage = debugfs_create_dir("swiotlb", NULL);

if (!d_swiotlb_usage)
return -ENOMEM;

ent = debugfs_create_ulong("io_tlb_nslabs", 0400,
d_swiotlb_usage, &io_tlb_nslabs);
if (!ent)
goto fail;

ent = debugfs_create_ulong("io_tlb_used", 0400,
d_swiotlb_usage, &io_tlb_used);
if (!ent)
goto fail;

return 0;

fail:
debugfs_remove_recursive(d_swiotlb_usage);
return -ENOMEM;
}

late_initcall(swiotlb_create_debugfs);

#endif

0 comments on commit 71602fe

Please sign in to comment.