Skip to content

Commit

Permalink
net: qualcomm: rmnet: Remove redundant command check
Browse files Browse the repository at this point in the history
The command packet size is already checked once in
rmnet_map_deaggregate() for the header, packet and trailer size, so
this additional check is not needed.

Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Subash Abhinov Kasiviswanathan authored and David S. Miller committed May 16, 2018
1 parent bbde32d commit 721ce0f
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,9 @@ static void rmnet_map_send_ack(struct sk_buff *skb,
struct rmnet_map_control_command *cmd;
int xmit_status;

if (port->data_format & RMNET_FLAGS_INGRESS_MAP_CKSUMV4) {
if (skb->len < sizeof(struct rmnet_map_header) +
RMNET_MAP_GET_LENGTH(skb) +
sizeof(struct rmnet_map_dl_csum_trailer)) {
kfree_skb(skb);
return;
}

skb_trim(skb, skb->len -
sizeof(struct rmnet_map_dl_csum_trailer));
}
if (port->data_format & RMNET_FLAGS_INGRESS_MAP_CKSUMV4)
skb_trim(skb,
skb->len - sizeof(struct rmnet_map_dl_csum_trailer));

skb->protocol = htons(ETH_P_MAP);

Expand Down

0 comments on commit 721ce0f

Please sign in to comment.