Skip to content

Commit

Permalink
regmap: merge regmap_field_update_bits() into macro
Browse files Browse the repository at this point in the history
This patch merges regmap_field_update_bits() into macro
by using regmap_field_update_bits_base().

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Kuninori Morimoto authored and Mark Brown committed Feb 19, 2016
1 parent 3674124 commit 721ed64
Showing 2 changed files with 2 additions and 22 deletions.
20 changes: 0 additions & 20 deletions drivers/base/regmap/regmap.c
Original file line number Diff line number Diff line change
@@ -1716,26 +1716,6 @@ int regmap_field_update_bits_base(struct regmap_field *field,
}
EXPORT_SYMBOL_GPL(regmap_field_update_bits_base);

/**
* regmap_field_update_bits(): Perform a read/modify/write cycle
* on the register field
*
* @field: Register field to write to
* @mask: Bitmask to change
* @val: Value to be written
*
* A value of zero will be returned on success, a negative errno will
* be returned in error cases.
*/
int regmap_field_update_bits(struct regmap_field *field, unsigned int mask, unsigned int val)
{
mask = (mask << field->shift) & field->mask;

return regmap_update_bits(field->regmap, field->reg,
mask, val << field->shift);
}
EXPORT_SYMBOL_GPL(regmap_field_update_bits);

/**
* regmap_fields_write(): Write a value to a single register field with port ID
*
4 changes: 2 additions & 2 deletions include/linux/regmap.h
Original file line number Diff line number Diff line change
@@ -76,6 +76,8 @@ struct reg_sequence {

#define regmap_field_write(field, val) \
regmap_field_update_bits_base(field, ~0, val, NULL, false, false)
#define regmap_field_update_bits(field, mask, val)\
regmap_field_update_bits_base(field, mask, val, NULL, false, false)

#ifdef CONFIG_REGMAP

@@ -778,8 +780,6 @@ int regmap_field_read(struct regmap_field *field, unsigned int *val);
int regmap_field_update_bits_base(struct regmap_field *field,
unsigned int mask, unsigned int val,
bool *change, bool async, bool force);
int regmap_field_update_bits(struct regmap_field *field,
unsigned int mask, unsigned int val);
int regmap_fields_write(struct regmap_field *field, unsigned int id,
unsigned int val);
int regmap_fields_force_write(struct regmap_field *field, unsigned int id,

0 comments on commit 721ed64

Please sign in to comment.