Skip to content

Commit

Permalink
x86: Fix typo preventing msr_set/clear_bit from having an effect
Browse files Browse the repository at this point in the history
Due to a typo the msr accessor function introduced in
22085a6 didn't have any lasting
effects because they accidentally wrote the old value back.

After c0a639a this at the very least
this causes cpuid limits not to be lifted on some cpus leading to
missing capabilities for those.

Signed-off-by: Andres Freund <andres@anarazel.de>
Link: http://lkml.kernel.org/r/1399598957-7011-2-git-send-email-andres@anarazel.de
Cc: Borislav Petkov <bp@suse.de>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
  • Loading branch information
Andres Freund authored and H. Peter Anvin committed May 9, 2014
1 parent 6218791 commit 722a0d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/lib/msr.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ static inline int __flip_bit(u32 msr, u8 bit, bool set)
if (m1.q == m.q)
return 0;

err = msr_write(msr, &m);
err = msr_write(msr, &m1);
if (err)
return err;

Expand Down

0 comments on commit 722a0d2

Please sign in to comment.