bsr: do not use assignment in if condition

checkpatch.pl does not like assignment in if condition Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mariux64 · May 24, 2019 · 7256d7f · 7256d7f
1 parent b0576f9
commit 7256d7f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
@@ -322,7 +322,8 @@ static int __init bsr_init(void)
 		goto out_err_2;
 	}
 
-	if ((ret = bsr_create_devs(np)) < 0) {
+	ret = bsr_create_devs(np);
+	if (ret < 0) {
 		np = NULL;
 		goto out_err_3;
 	}