Skip to content

Commit

Permalink
ata: libata: Improve return value of atapi_check_dma()
Browse files Browse the repository at this point in the history
atapi_check_dma() allows a LLD to filter ATAPI commands, returning a
status indicating whether or not it is OK to use DMA for the supplied
ATAPI command.

Change atapi_check_dma() to return -EOPNOTSUPP instead of 1 for an
ATAPI command that is not allowed to use DMA.

Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Link: https://lore.kernel.org/r/20250312133954.6666-1-chenhuacai@loongson.cn
[cassel: improve commit log]
Signed-off-by: Niklas Cassel <cassel@kernel.org>
  • Loading branch information
Huacai Chen authored and Niklas Cassel committed Mar 12, 2025
1 parent 885251d commit 725ad02
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ata/libata-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -4579,7 +4579,7 @@ int atapi_check_dma(struct ata_queued_cmd *qc)
*/
if (!(qc->dev->quirks & ATA_QUIRK_ATAPI_MOD16_DMA) &&
unlikely(qc->nbytes & 15))
return 1;
return -EOPNOTSUPP;

if (ap->ops->check_atapi_dma)
return ap->ops->check_atapi_dma(qc);
Expand Down

0 comments on commit 725ad02

Please sign in to comment.