Skip to content

Commit

Permalink
riscv: add missing newlines to printk messages
Browse files Browse the repository at this point in the history
Add missing newline characters to printk messages.

Also replace two pr_warning with the shorter pr_warn, and fix up the
tense of one error message while at it.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
  • Loading branch information
Johan Hovold authored and Palmer Dabbelt committed Feb 11, 2019
1 parent 41fb9d5 commit 7265d10
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion arch/riscv/kernel/cpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ static void print_isa(struct seq_file *f, const char *orig_isa)
* a bit of info describing what went wrong.
*/
if (isa[0] != '\0')
pr_info("unsupported ISA \"%s\" in device tree", orig_isa);
pr_info("unsupported ISA \"%s\" in device tree\n", orig_isa);
}

static void print_mmu(struct seq_file *f, const char *mmu_type)
Expand Down
8 changes: 4 additions & 4 deletions arch/riscv/kernel/cpufeature.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ void riscv_fill_hwcap(void)
if (riscv_of_processor_hartid(node) >= 0)
break;
if (!node) {
pr_warning("Unable to find \"cpu\" devicetree entry");
pr_warn("Unable to find \"cpu\" devicetree entry\n");
return;
}

if (of_property_read_string(node, "riscv,isa", &isa)) {
pr_warning("Unable to find \"riscv,isa\" devicetree entry");
pr_warn("Unable to find \"riscv,isa\" devicetree entry\n");
of_node_put(node);
return;
}
Expand All @@ -67,11 +67,11 @@ void riscv_fill_hwcap(void)
/* We don't support systems with F but without D, so mask those out
* here. */
if ((elf_hwcap & COMPAT_HWCAP_ISA_F) && !(elf_hwcap & COMPAT_HWCAP_ISA_D)) {
pr_info("This kernel does not support systems with F but not D");
pr_info("This kernel does not support systems with F but not D\n");
elf_hwcap &= ~COMPAT_HWCAP_ISA_F;
}

pr_info("elf_hwcap is 0x%lx", elf_hwcap);
pr_info("elf_hwcap is 0x%lx\n", elf_hwcap);

#ifdef CONFIG_FPU
if (elf_hwcap & (COMPAT_HWCAP_ISA_F | COMPAT_HWCAP_ISA_D))
Expand Down
2 changes: 1 addition & 1 deletion arch/riscv/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ static int ftrace_check_current_call(unsigned long hook_pos,
* return must be -EINVAL on failed comparison
*/
if (memcmp(expected, replaced, sizeof(replaced))) {
pr_err("%p: expected (%08x %08x) but get (%08x %08x)",
pr_err("%p: expected (%08x %08x) but got (%08x %08x)\n",
(void *)hook_pos, expected[0], expected[1], replaced[0],
replaced[1]);
return -EINVAL;
Expand Down

0 comments on commit 7265d10

Please sign in to comment.