Skip to content

Commit

Permalink
edac: Unify reporting of device info for device, mc and pci
Browse files Browse the repository at this point in the history
Log messages slightly differ between edac subsystems. Unifying it.

Signed-off-by: Robert Richter <robert.richter@linaro.org>
Acked-by: Rob Herring <rob.herring@calxeda.com>
Acked-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Robert Richter <rric@kernel.org>
  • Loading branch information
Robert Richter authored and Robert Richter committed Nov 4, 2013
1 parent 41ec0e8 commit 7270a60
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 13 deletions.
9 changes: 3 additions & 6 deletions drivers/edac/edac_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -530,12 +530,9 @@ int edac_device_add_device(struct edac_device_ctl_info *edac_dev)

/* Report action taken */
edac_device_printk(edac_dev, KERN_INFO,
"Giving out device to module '%s' controller "
"'%s': DEV '%s' (%s)\n",
edac_dev->mod_name,
edac_dev->ctl_name,
edac_dev_name(edac_dev),
edac_op_state_to_string(edac_dev->op_state));
"Giving out device to module %s controller %s: DEV %s (%s)\n",
edac_dev->mod_name, edac_dev->ctl_name, edac_dev->dev_name,
edac_op_state_to_string(edac_dev->op_state));

mutex_unlock(&device_ctls_mutex);
return 0;
Expand Down
6 changes: 4 additions & 2 deletions drivers/edac/edac_mc.c
Original file line number Diff line number Diff line change
Expand Up @@ -788,8 +788,10 @@ int edac_mc_add_mc(struct mem_ctl_info *mci)
}

/* Report action taken */
edac_mc_printk(mci, KERN_INFO, "Giving out device to '%s' '%s':"
" DEV %s\n", mci->mod_name, mci->ctl_name, edac_dev_name(mci));
edac_mc_printk(mci, KERN_INFO,
"Giving out device to module %s controller %s: DEV %s (%s)\n",
mci->mod_name, mci->ctl_name, mci->dev_name,
edac_op_state_to_string(mci->op_state));

edac_mc_owner = mci->mod_name;

Expand Down
8 changes: 3 additions & 5 deletions drivers/edac/edac_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -358,11 +358,9 @@ int edac_pci_add_device(struct edac_pci_ctl_info *pci, int edac_idx)
}

edac_pci_printk(pci, KERN_INFO,
"Giving out device to module '%s' controller '%s':"
" DEV '%s' (%s)\n",
pci->mod_name,
pci->ctl_name,
edac_dev_name(pci), edac_op_state_to_string(pci->op_state));
"Giving out device to module %s controller %s: DEV %s (%s)\n",
pci->mod_name, pci->ctl_name, pci->dev_name,
edac_op_state_to_string(pci->op_state));

mutex_unlock(&edac_pci_ctls_mutex);
return 0;
Expand Down

0 comments on commit 7270a60

Please sign in to comment.