Skip to content

Commit

Permalink
selftests/bpf: Add assert for user stacks in test_task_stack
Browse files Browse the repository at this point in the history
This is a follow up to:
commit b8e3a87 ("bpf: Add crosstask check to __bpf_get_stack").

This test ensures that the task iterator only gets a single
user stack (for the current task).

Signed-off-by: Jordan Rome <linux@jordanrome.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/bpf/20231112023010.144675-1-linux@jordanrome.com
  • Loading branch information
Jordan Rome authored and Andrii Nakryiko committed Nov 14, 2023
1 parent 100888f commit 727a92d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tools/testing/selftests/bpf/prog_tests/bpf_iter.c
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,8 @@ static void test_task_stack(void)
do_dummy_read(skel->progs.dump_task_stack);
do_dummy_read(skel->progs.get_task_user_stacks);

ASSERT_EQ(skel->bss->num_user_stacks, 1, "num_user_stacks");

bpf_iter_task_stack__destroy(skel);
}

Expand Down
5 changes: 5 additions & 0 deletions tools/testing/selftests/bpf/progs/bpf_iter_task_stack.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ int dump_task_stack(struct bpf_iter__task *ctx)
return 0;
}

int num_user_stacks = 0;

SEC("iter/task")
int get_task_user_stacks(struct bpf_iter__task *ctx)
{
Expand All @@ -51,6 +53,9 @@ int get_task_user_stacks(struct bpf_iter__task *ctx)
if (res <= 0)
return 0;

/* Only one task, the current one, should succeed */
++num_user_stacks;

buf_sz += res;

/* If the verifier doesn't refine bpf_get_task_stack res, and instead
Expand Down

0 comments on commit 727a92d

Please sign in to comment.