Skip to content

Commit

Permalink
drm/doc/rfc: drop the i915_gem_lmem.h header
Browse files Browse the repository at this point in the history
The proper headers have now landed in include/uapi/drm/i915_drm.h, so we
can drop i915_gem_lmem.h and instead just reference the real headers for
pulling in the kernel doc.

Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210511170356.430284-1-matthew.auld@intel.com
  • Loading branch information
Matthew Auld committed May 12, 2021
1 parent 00d6dc3 commit 727ecd9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 240 deletions.
237 changes: 0 additions & 237 deletions Documentation/gpu/rfc/i915_gem_lmem.h

This file was deleted.

6 changes: 3 additions & 3 deletions Documentation/gpu/rfc/i915_gem_lmem.rst
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ particular instance, since we can have more than one per class.
In the future we also want to expose more information which can further
describe the capabilities of a region.

.. kernel-doc:: Documentation/gpu/rfc/i915_gem_lmem.h
.. kernel-doc:: include/uapi/drm/i915_drm.h
:functions: drm_i915_gem_memory_class drm_i915_gem_memory_class_instance drm_i915_memory_region_info drm_i915_query_memory_regions

GEM_CREATE_EXT
Expand All @@ -61,7 +61,7 @@ Side note: We also need to support PXP[1] in the near future, which is also
applicable to integrated platforms, and adds its own gem_create_ext extension,
which basically lets userspace mark a buffer as "protected".

.. kernel-doc:: Documentation/gpu/rfc/i915_gem_lmem.h
.. kernel-doc:: include/uapi/drm/i915_drm.h
:functions: drm_i915_gem_create_ext

I915_GEM_CREATE_EXT_MEMORY_REGIONS
Expand All @@ -73,7 +73,7 @@ them each to use the class/instance encoding, as per the output of the regions
query. Having the list in priority order will be useful in the future when
placing an object, say during eviction.

.. kernel-doc:: Documentation/gpu/rfc/i915_gem_lmem.h
.. kernel-doc:: include/uapi/drm/i915_drm.h
:functions: drm_i915_gem_create_ext_memory_regions

One fair criticism here is that this seems a little over-engineered[2]. If we
Expand Down

0 comments on commit 727ecd9

Please sign in to comment.