Skip to content

Commit

Permalink
clk: mediatek: clk-mt8195-topckgen: Drop univplls from mfg mux parents
Browse files Browse the repository at this point in the history
These PLLs are conflicting with GPU rates that can be generated by
the GPU-dedicated MFGPLL and would require a special clock handler
to be used, for very little and ignorable power consumption benefits.
Also, we're in any case unable to set the rate of these PLLs to
something else that is sensible for this task, so simply drop them:
this will make the GPU to be clocked exclusively from MFGPLL for
"fast" rates, while still achieving the right "safe" rate during
PLL frequency locking.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Link: https://lore.kernel.org/r/20220927101128.44758-9-angelogioacchino.delregno@collabora.com
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
  • Loading branch information
AngeloGioacchino Del Regno authored and Chen-Yu Tsai committed Sep 29, 2022
1 parent f8fd4b5 commit 72d38ed
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions drivers/clk/mediatek/clk-mt8195-topckgen.c
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,14 @@ static const char * const ipu_if_parents[] = {
"mmpll_d4"
};

/*
* MFG can be also parented to "univpll_d6" and "univpll_d7":
* these have been removed from the parents list to let us
* achieve GPU DVFS without any special clock handlers.
*/
static const char * const mfg_parents[] = {
"clk26m",
"mainpll_d5_d2",
"univpll_d6",
"univpll_d7"
"mainpll_d5_d2"
};

static const char * const camtg_parents[] = {
Expand Down

0 comments on commit 72d38ed

Please sign in to comment.