Skip to content

Commit

Permalink
selftests: rtnetlink: make kci_test_encap() return sub-test result
Browse files Browse the repository at this point in the history
kci_test_encap() is actually composed by two different sub-tests,
kci_test_encap_vxlan() and kci_test_encap_fou()

Therefore we should check the test result of these two in
kci_test_encap() to let the script be aware of the pass / fail status.
Otherwise it will generate false-negative result like below:
    $ sudo ./test.sh
    PASS: policy routing
    PASS: route get
    PASS: preferred_lft addresses have expired
    PASS: promote_secondaries complete
    PASS: tc htb hierarchy
    PASS: gre tunnel endpoint
    PASS: gretap
    PASS: ip6gretap
    PASS: erspan
    PASS: ip6erspan
    PASS: bridge setup
    PASS: ipv6 addrlabel
    PASS: set ifalias 5b193daf-0a08-46d7-af2c-e7aadd422ded for test-dummy0
    PASS: vrf
    PASS: vxlan
    FAIL: can't add fou port 7777, skipping test
    PASS: macsec
    PASS: bridge fdb get
    PASS: neigh get
    $ echo $?
    0

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Po-Hsu Lin authored and David S. Miller committed Aug 5, 2020
1 parent c2a4d27 commit 72f70c1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tools/testing/selftests/net/rtnetlink.sh
Original file line number Diff line number Diff line change
Expand Up @@ -564,9 +564,12 @@ kci_test_encap()
check_err $?

kci_test_encap_vxlan "$testns"
check_err $?
kci_test_encap_fou "$testns"
check_err $?

ip netns del "$testns"
return $ret
}

kci_test_macsec()
Expand Down

0 comments on commit 72f70c1

Please sign in to comment.