Skip to content

Commit

Permalink
ocfs2: use proper little-endian bitops
Browse files Browse the repository at this point in the history
Using __test_and_{set,clear}_bit_le() with ignoring its return value
can be replaced with __{set,clear}_bit_le().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: ocfs2-devel@oss.oracle.com
Signed-off-by: Joel Becker <jlbec@evilplan.org>
  • Loading branch information
Akinobu Mita authored and Joel Becker committed Jun 1, 2011
1 parent 87f0d5c commit 730e663
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/ocfs2/ocfs2.h
Original file line number Diff line number Diff line change
Expand Up @@ -836,13 +836,13 @@ static inline unsigned int ocfs2_clusters_to_megabytes(struct super_block *sb,

static inline void _ocfs2_set_bit(unsigned int bit, unsigned long *bitmap)
{
__test_and_set_bit_le(bit, bitmap);
__set_bit_le(bit, bitmap);
}
#define ocfs2_set_bit(bit, addr) _ocfs2_set_bit((bit), (unsigned long *)(addr))

static inline void _ocfs2_clear_bit(unsigned int bit, unsigned long *bitmap)
{
__test_and_clear_bit_le(bit, bitmap);
__clear_bit_le(bit, bitmap);
}
#define ocfs2_clear_bit(bit, addr) _ocfs2_clear_bit((bit), (unsigned long *)(addr))

Expand Down

0 comments on commit 730e663

Please sign in to comment.