Skip to content

Commit

Permalink
[SCTP]: Fix SACK sequence during shutdown
Browse files Browse the repository at this point in the history
Currently, when association enters SHUTDOWN state,the
implementation will SACK any DATA first and then transmit
the SHUTDOWN chunk.  This is against the order required by
2960bis spec.  SHUTDOWN must always be first, followed by
SACK. This change forces this order and also enables bundling.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Vlad Yasevich authored and David S. Miller committed Jan 24, 2007
1 parent 610ab73 commit 732ba35
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/sctp/sm_sideeffect.c
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ static int sctp_gen_sack(struct sctp_association *asoc, int force,

asoc->peer.sack_needed = 0;

error = sctp_outq_tail(&asoc->outqueue, sack);
sctp_add_cmd_sf(commands, SCTP_CMD_REPLY, SCTP_CHUNK(sack));

/* Stop the SACK timer. */
sctp_add_cmd_sf(commands, SCTP_CMD_TIMER_STOP,
Expand Down

0 comments on commit 732ba35

Please sign in to comment.