Skip to content

Commit

Permalink
drm/i915/execlists: Detect cross-contamination with GuC
Browse files Browse the repository at this point in the history
The process_csb routine from execlists_submission is incompatible with
the GuC backend. Add a warning to detect if we accidentally end up in
the wrong spot.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Michał Winiarski <michal.winiarski@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190618110736.31155-1-chris@chris-wilson.co.uk
  • Loading branch information
Chris Wilson committed Jun 19, 2019
1 parent 44d8940 commit 7359134
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/gpu/drm/i915/gt/intel_lrc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1169,6 +1169,7 @@ static void process_csb(struct intel_engine_cs *engine)
u8 head, tail;

lockdep_assert_held(&engine->active.lock);
GEM_BUG_ON(USES_GUC_SUBMISSION(engine->i915));

/*
* Note that csb_write, csb_status may be either in HWSP or mmio.
Expand Down

0 comments on commit 7359134

Please sign in to comment.