Skip to content

Commit

Permalink
drm/xe/query: Tidy up error EFAULT returns
Browse files Browse the repository at this point in the history
Move the error handling together in a single branch since all of them
are doing similar thing and return the same error.

Reviewed-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241011035618.1057602-3-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
  • Loading branch information
Lucas De Marchi committed Oct 12, 2024
1 parent 5c84985 commit 735be7a
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions drivers/gpu/drm/xe/xe_query.c
Original file line number Diff line number Diff line change
Expand Up @@ -163,16 +163,10 @@ query_engine_cycles(struct xe_device *xe,
resp.width = 36;

/* Only write to the output fields of user query */
if (put_user(resp.cpu_timestamp, &query_ptr->cpu_timestamp))
return -EFAULT;

if (put_user(resp.cpu_delta, &query_ptr->cpu_delta))
return -EFAULT;

if (put_user(resp.engine_cycles, &query_ptr->engine_cycles))
return -EFAULT;

if (put_user(resp.width, &query_ptr->width))
if (put_user(resp.cpu_timestamp, &query_ptr->cpu_timestamp) ||
put_user(resp.cpu_delta, &query_ptr->cpu_delta) ||
put_user(resp.engine_cycles, &query_ptr->engine_cycles) ||
put_user(resp.width, &query_ptr->width))
return -EFAULT;

return 0;
Expand Down

0 comments on commit 735be7a

Please sign in to comment.