Skip to content

Commit

Permalink
tracing: Remove redundant reset per-CPU buff in irqsoff tracer
Browse files Browse the repository at this point in the history
  There is no reason to do it twice: from commit b6f11df
("trace: Call tracing_reset_online_cpus before tracer->init()")
resetting of per-CPU buffers done before tracer->init() call.

tracer->init() calls {irqs,preempt,preemptirqs}off_tracer_init() and it
calls __irqsoff_tracer_init(), which resets per-CPU ringbuffer second
time.
It's slowpath, but anyway.

Link: http://lkml.kernel.org/r/1445278226-16187-1-git-send-email-0x7f454c46@gmail.com

Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Dmitry Safonov authored and Steven Rostedt committed Mar 18, 2016
1 parent 9d2099a commit 741f3a6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion kernel/trace/trace_irqsoff.c
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,6 @@ static int __irqsoff_tracer_init(struct trace_array *tr)
irqsoff_trace = tr;
/* make sure that the tracer is visible */
smp_wmb();
tracing_reset_online_cpus(&tr->trace_buffer);

ftrace_init_array_ops(tr, irqsoff_tracer_call);

Expand Down

0 comments on commit 741f3a6

Please sign in to comment.