Skip to content

Commit

Permalink
drivers: net: cpsw: remove pm runtime calls from suspend callbacks
Browse files Browse the repository at this point in the history
PM runtime is properly handled in cpsw_ndo_open/stop(), as result it
isn't required to duplicate these calls in .suspend()/.resume()
callbacks. Moreover, it might cause unnecessary RPM resume of CPSW
during System suspend in the case it's already suspended because
all ethX interfaces are down already, before System suspend started.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Grygorii Strashko authored and David S. Miller committed Jun 28, 2016
1 parent 108a653 commit 74556f5
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/net/ethernet/ti/cpsw.c
Original file line number Diff line number Diff line change
Expand Up @@ -2563,8 +2563,6 @@ static int cpsw_suspend(struct device *dev)
cpsw_ndo_stop(ndev);
}

pm_runtime_put_sync(&pdev->dev);

/* Select sleep pin state */
pinctrl_pm_select_sleep_state(&pdev->dev);

Expand All @@ -2577,8 +2575,6 @@ static int cpsw_resume(struct device *dev)
struct net_device *ndev = platform_get_drvdata(pdev);
struct cpsw_priv *priv = netdev_priv(ndev);

pm_runtime_get_sync(&pdev->dev);

/* Select default pin state */
pinctrl_pm_select_default_state(&pdev->dev);

Expand Down

0 comments on commit 74556f5

Please sign in to comment.