Skip to content

Commit

Permalink
cpuidle: menu: fixed wrapping timers at 4.294 seconds
Browse files Browse the repository at this point in the history
Cpuidle menu governor is using u32 as a temporary datatype for storing
nanosecond values which wrap around at 4.294 seconds. This causes errors
in predicted sleep times resulting in higher than should be C state
selection and increased power consumption. This also breaks cpuidle
state residency statistics.

cc: stable@kernel.org # .32.x through .39.x
Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Tero Kristo authored and Len Brown committed May 29, 2011
1 parent 521cb40 commit 7467571
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/cpuidle/governors/menu.c
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ static int menu_select(struct cpuidle_device *dev)
unsigned int power_usage = -1;
int i;
int multiplier;
struct timespec t;

if (data->needs_update) {
menu_update(dev);
Expand All @@ -251,8 +252,9 @@ static int menu_select(struct cpuidle_device *dev)
return 0;

/* determine the expected residency time, round up */
t = ktime_to_timespec(tick_nohz_get_sleep_length());
data->expected_us =
DIV_ROUND_UP((u32)ktime_to_ns(tick_nohz_get_sleep_length()), 1000);
t.tv_sec * USEC_PER_SEC + t.tv_nsec / NSEC_PER_USEC;


data->bucket = which_bucket(data->expected_us);
Expand Down

0 comments on commit 7467571

Please sign in to comment.