Skip to content

Commit

Permalink
sctp: merge two if statements to one
Browse files Browse the repository at this point in the history
Two if statements do the same work, we can merge them to
one. And fix some typos. There is just code simplification,
no functional changes.

Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
wangweidong authored and David S. Miller committed Oct 28, 2013
1 parent 3dc0a54 commit 747edc0
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions net/sctp/auth.c
Original file line number Diff line number Diff line change
Expand Up @@ -539,18 +539,14 @@ struct sctp_hmac *sctp_auth_asoc_get_hmac(const struct sctp_association *asoc)
for (i = 0; i < n_elt; i++) {
id = ntohs(hmacs->hmac_ids[i]);

/* Check the id is in the supported range */
if (id > SCTP_AUTH_HMAC_ID_MAX) {
id = 0;
continue;
}

/* See is we support the id. Supported IDs have name and
* length fields set, so that we can allocated and use
/* Check the id is in the supported range. And
* see if we support the id. Supported IDs have name and
* length fields set, so that we can allocate and use
* them. We can safely just check for name, for without the
* name, we can't allocate the TFM.
*/
if (!sctp_hmac_list[id].hmac_name) {
if (id > SCTP_AUTH_HMAC_ID_MAX ||
!sctp_hmac_list[id].hmac_name) {
id = 0;
continue;
}
Expand Down

0 comments on commit 747edc0

Please sign in to comment.