Skip to content

Commit

Permalink
i40evf: disable NAPI polling sooner
Browse files Browse the repository at this point in the history
When closing the interface, disable NAPI polling before any other
activities. This fixes an occasional panic during close caused by the
driver trying to delete and clean rings at the same time.

Change-ID: Ib4d427b13d310258ea85b248d535da70ecf0c1e9
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Jim Young <james.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
  • Loading branch information
Mitch Williams authored and Jeff Kirsher committed Feb 24, 2015
1 parent 30d71af commit 748c434
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/ethernet/intel/i40evf/i40evf_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,7 @@ void i40evf_down(struct i40evf_adapter *adapter)
usleep_range(500, 1000);

i40evf_irq_disable(adapter);
i40evf_napi_disable_all(adapter);

/* remove all MAC filters */
list_for_each_entry(f, &adapter->mac_filter_list, list) {
Expand All @@ -985,8 +986,6 @@ void i40evf_down(struct i40evf_adapter *adapter)

netif_tx_stop_all_queues(netdev);

i40evf_napi_disable_all(adapter);

msleep(20);

netif_carrier_off(netdev);
Expand Down

0 comments on commit 748c434

Please sign in to comment.