Skip to content

Commit

Permalink
cxgb4: speed up on-chip memory read
Browse files Browse the repository at this point in the history
Use readq() (via t4_read_reg64()) to read 64-bits at a time.
Read residual in 32-bit multiples.

Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Rahul Lakkireddy authored and David S. Miller committed Feb 14, 2018
1 parent 1a4330c commit 7494f98
Showing 1 changed file with 28 additions and 9 deletions.
37 changes: 28 additions & 9 deletions drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -884,18 +884,19 @@ static int cudbg_memory_read(struct cudbg_init *pdbg_init, int win,
u32 win_pf, memoffset, mem_aperture, mem_base;
struct adapter *adap = pdbg_init->adap;
u32 pos, offset, resid;
u32 *buf;
u32 *res_buf;
u64 *buf;
int ret;

/* Argument sanity checks ...
*/
if (addr & 0x3 || (uintptr_t)hbuf & 0x3)
return -EINVAL;

buf = (u32 *)hbuf;
buf = (u64 *)hbuf;

/* Try to do 32-bit reads. Residual will be handled later. */
resid = len & 0x3;
/* Try to do 64-bit reads. Residual will be handled later. */
resid = len & 0x7;
len -= resid;

ret = t4_memory_rw_init(adap, win, mtype, &memoffset, &mem_base,
Expand All @@ -916,10 +917,28 @@ static int cudbg_memory_read(struct cudbg_init *pdbg_init, int win,

/* Transfer data from the adapter */
while (len > 0) {
*buf++ = le32_to_cpu((__force __le32)
t4_read_reg(adap, mem_base + offset));
*buf++ = le64_to_cpu((__force __le64)
t4_read_reg64(adap, mem_base + offset));
offset += sizeof(u64);
len -= sizeof(u64);

/* If we've reached the end of our current window aperture,
* move the PCI-E Memory Window on to the next.
*/
if (offset == mem_aperture) {
pos += mem_aperture;
offset = 0;
t4_memory_update_win(adap, win, pos | win_pf);
}
}

res_buf = (u32 *)buf;
/* Read residual in 32-bit multiples */
while (resid > sizeof(u32)) {
*res_buf++ = le32_to_cpu((__force __le32)
t4_read_reg(adap, mem_base + offset));
offset += sizeof(u32);
len -= sizeof(u32);
resid -= sizeof(u32);

/* If we've reached the end of our current window aperture,
* move the PCI-E Memory Window on to the next.
Expand All @@ -931,10 +950,10 @@ static int cudbg_memory_read(struct cudbg_init *pdbg_init, int win,
}
}

/* Transfer residual */
/* Transfer residual < 32-bits */
if (resid)
t4_memory_rw_residual(adap, resid, mem_base + offset,
(u8 *)buf, T4_MEMORY_READ);
(u8 *)res_buf, T4_MEMORY_READ);

return 0;
}
Expand Down

0 comments on commit 7494f98

Please sign in to comment.