Skip to content

Commit

Permalink
hwmon: (asus_atk0110) Use str_enabled_disabled() and str_enable_disab…
Browse files Browse the repository at this point in the history
…le() helpers

Remove hard-coded strings by using the str_enabled_disabled() and
str_enable_disable() helper functions.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://lore.kernel.org/r/20250112105128.86653-2-thorsten.blum@linux.dev
[groeck: Fixed subject and continuation line alignments]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Thorsten Blum authored and Guenter Roeck committed Jan 12, 2025
1 parent c8571ea commit 74a2594
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions drivers/hwmon/asus_atk0110.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include <linux/jiffies.h>
#include <linux/err.h>
#include <linux/acpi.h>
#include <linux/string_choices.h>

#define ATK_HID "ATK0110"

Expand Down Expand Up @@ -441,7 +442,7 @@ static void atk_print_sensor(struct atk_data *data, union acpi_object *obj)
flags->integer.value,
name->string.pointer,
limit1->integer.value, limit2->integer.value,
enable->integer.value ? "enabled" : "disabled");
str_enabled_disabled(enable->integer.value));
#endif
}

Expand Down Expand Up @@ -1074,8 +1075,7 @@ static int atk_ec_enabled(struct atk_data *data)
err = -EIO;
} else {
err = (buf->value != 0);
dev_dbg(dev, "EC is %sabled\n",
err ? "en" : "dis");
dev_dbg(dev, "EC is %s\n", str_enabled_disabled(err));
}

ACPI_FREE(obj);
Expand All @@ -1096,18 +1096,15 @@ static int atk_ec_ctl(struct atk_data *data, int enable)

obj = atk_sitm(data, &sitm);
if (IS_ERR(obj)) {
dev_err(dev, "Failed to %sable the EC\n",
enable ? "en" : "dis");
dev_err(dev, "Failed to %s the EC\n", str_enable_disable(enable));
return PTR_ERR(obj);
}
ec_ret = (struct atk_acpi_ret_buffer *)obj->buffer.pointer;
if (ec_ret->flags == 0) {
dev_err(dev, "Failed to %sable the EC\n",
enable ? "en" : "dis");
dev_err(dev, "Failed to %s the EC\n", str_enable_disable(enable));
err = -EIO;
} else {
dev_info(dev, "EC %sabled\n",
enable ? "en" : "dis");
dev_info(dev, "EC %s\n", str_enabled_disabled(enable));
}

ACPI_FREE(obj);
Expand Down

0 comments on commit 74a2594

Please sign in to comment.