Skip to content

Commit

Permalink
Merge tag 'pull-fixes' of git://git.kernel.org/pub/scm/linux/kernel/g…
Browse files Browse the repository at this point in the history
…it/viro/vfs

Pull vfs lseek fix from Al Viro:
 "Fix proc_reg_llseek() breakage. Always had been possible if somebody
  left NULL ->proc_lseek, became a practical issue now"

* tag 'pull-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
  take care to handle NULL ->proc_lseek()
  • Loading branch information
Linus Torvalds committed Aug 14, 2022
2 parents 5d6a0f4 + 3f61631 commit 74cbb48
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions fs/proc/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,9 @@ static int proc_reg_open(struct inode *inode, struct file *file)
typeof_member(struct proc_ops, proc_release) release;
struct pde_opener *pdeo;

if (!pde->proc_ops->proc_lseek)
file->f_mode &= ~FMODE_LSEEK;

if (pde_is_permanent(pde)) {
open = pde->proc_ops->proc_open;
if (open)
Expand Down

0 comments on commit 74cbb48

Please sign in to comment.