namei: simplify invalidation logics in lookup_dcache()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
mariux64 · Mar 14, 2016 · 74ff0ff · 74ff0ff
1 parent e9742b5
commit 74ff0ff
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/fs/namei.c b/fs/namei.c
@@ -1458,14 +1458,10 @@ static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir,
 		if (dentry->d_flags & DCACHE_OP_REVALIDATE) {
 			error = d_revalidate(dentry, flags);
 			if (unlikely(error <= 0)) {
-				if (error < 0) {
-					dput(dentry);
-					return ERR_PTR(error);
-				} else {
+				if (!error)
 					d_invalidate(dentry);
-					dput(dentry);
-					dentry = NULL;
-				}
+				dput(dentry);
+				return ERR_PTR(error);
 			}
 		}
 	}