Skip to content

Commit

Permalink
net/packet: Ask driver for protocol if not provided by user
Browse files Browse the repository at this point in the history
If a socket was created with socket(AF_PACKET, SOCK_RAW, 0), the
protocol number is unavailable. Try to ask the driver to extract it from
the L2 header in order for skb_try_probe_transport_header to succeed.

Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Maxim Mikityanskiy authored and David S. Miller committed Feb 22, 2019
1 parent ace53b2 commit 75c6577
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions net/packet/af_packet.c
Original file line number Diff line number Diff line change
Expand Up @@ -1850,6 +1850,15 @@ static int packet_rcv_spkt(struct sk_buff *skb, struct net_device *dev,
return 0;
}

static void packet_parse_headers(struct sk_buff *skb, struct socket *sock)
{
if (!skb->protocol && sock->type == SOCK_RAW) {
skb_reset_mac_header(skb);
skb->protocol = dev_parse_header_protocol(skb);
}

skb_probe_transport_header(skb);
}

/*
* Output a raw packet to a device layer. This bypasses all the other
Expand Down Expand Up @@ -1970,7 +1979,7 @@ static int packet_sendmsg_spkt(struct socket *sock, struct msghdr *msg,
if (unlikely(extra_len == 4))
skb->no_fcs = 1;

skb_probe_transport_header(skb);
packet_parse_headers(skb, sock);

dev_queue_xmit(skb);
rcu_read_unlock();
Expand Down Expand Up @@ -2519,7 +2528,7 @@ static int tpacket_fill_skb(struct packet_sock *po, struct sk_buff *skb,
len = ((to_write > len_max) ? len_max : to_write);
}

skb_probe_transport_header(skb);
packet_parse_headers(skb, sock);

return tp_len;
}
Expand Down Expand Up @@ -2925,7 +2934,7 @@ static int packet_snd(struct socket *sock, struct msghdr *msg, size_t len)
virtio_net_hdr_set_proto(skb, &vnet_hdr);
}

skb_probe_transport_header(skb);
packet_parse_headers(skb, sock);

if (unlikely(extra_len == 4))
skb->no_fcs = 1;
Expand Down

0 comments on commit 75c6577

Please sign in to comment.