Skip to content

Commit

Permalink
drm/mgag200: set variable mgag200_modeset storage-class-specifier to …
Browse files Browse the repository at this point in the history
…static

smatch reports
drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol
  'mgag200_modeset' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230517134140.874179-1-trix@redhat.com
  • Loading branch information
Tom Rix authored and Jocelyn Falempe committed Jun 23, 2023
1 parent 05aa613 commit 75f2d61
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/mgag200/mgag200_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

#include "mgag200_drv.h"

int mgag200_modeset = -1;
static int mgag200_modeset = -1;
MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
module_param_named(modeset, mgag200_modeset, int, 0400);

Expand Down

0 comments on commit 75f2d61

Please sign in to comment.