Skip to content

Commit

Permalink
powerpc/8xx: Erroneous double irq_eoi() on CPM IRQ in MPC8xx
Browse files Browse the repository at this point in the history
irq_eoi() is already called by generic_handle_irq() so
it shall not be called a again

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Scott Wood <scottwood@freescale.com>
  • Loading branch information
LEROY Christophe authored and Scott Wood committed Jul 1, 2013
1 parent 2dd1c13 commit 7601f59
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions arch/powerpc/platforms/8xx/m8xx_setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,19 +219,12 @@ void mpc8xx_restart(char *cmd)

static void cpm_cascade(unsigned int irq, struct irq_desc *desc)
{
struct irq_chip *chip;
int cascade_irq;

if ((cascade_irq = cpm_get_irq()) >= 0) {
struct irq_desc *cdesc = irq_to_desc(cascade_irq);
struct irq_chip *chip = irq_desc_get_chip(desc);
int cascade_irq = cpm_get_irq();

if (cascade_irq >= 0)
generic_handle_irq(cascade_irq);

chip = irq_desc_get_chip(cdesc);
chip->irq_eoi(&cdesc->irq_data);
}

chip = irq_desc_get_chip(desc);
chip->irq_eoi(&desc->irq_data);
}

Expand Down

0 comments on commit 7601f59

Please sign in to comment.