Skip to content

Commit

Permalink
fbdev: fbcon: select VT_HW_CONSOLE_BINDING
Browse files Browse the repository at this point in the history
fbdev provides framebuffer hotplugging, hence, we need to allow fbcon to
unbind from framebuffers. Unfortunately, fbcon_fb_unbind() cannot unbind
from the last framebuffer, unless console-unbinding is supported.

Fixing fbcon_unbind() to return 0 caused some horrible NULL-derefs in the
VT layer and I couldn't figure out why. Hence, lets just require
console-unbinding so fbdev hotplugging works with fbcon.

Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Link: http://lkml.kernel.org/r/1375445127-15480-9-git-send-email-dh.herrmann@gmail.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
  • Loading branch information
David Herrmann authored and H. Peter Anvin committed Aug 2, 2013
1 parent e6816a8 commit 765d5b9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/video/console/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ config DUMMY_CONSOLE_ROWS

config FRAMEBUFFER_CONSOLE
tristate "Framebuffer Console support"
depends on FB
depends on FB && !UML
select VT_HW_CONSOLE_BINDING
select CRC32
select FONT_SUPPORT
help
Expand Down

0 comments on commit 765d5b9

Please sign in to comment.