Skip to content

Commit

Permalink
hamradio: 6pack: fix error return code
Browse files Browse the repository at this point in the history
Set the return variable to an error code as done elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julia Lawall authored and David S. Miller committed Jan 2, 2014
1 parent 4fc3ecd commit 769f01e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/hamradio/6pack.c
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,8 @@ static int sixpack_open(struct tty_struct *tty)
tty->receive_room = 65536;

/* Now we're ready to register. */
if (register_netdev(dev))
err = register_netdev(dev);
if (err)
goto out_free;

tnc_init(sp);
Expand Down

0 comments on commit 769f01e

Please sign in to comment.