Skip to content

Commit

Permalink
phy: qcom-qmp-combo: initialize PCS_USB registers
Browse files Browse the repository at this point in the history
Currently, PCS_USB registers that have their initialization data in a
pcs_usb_tbl table are never initialized. Fix that.

Fixes: fc64623 ("phy: qcom-qmp-combo,usb: add support for separate PCS_USB region")
Reported-by: Adrien Thierry <athierry@redhat.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230829-topic-8550_usbphy-v3-2-34ec434194c5@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
Konrad Dybcio authored and Vinod Koul committed Sep 21, 2023
1 parent 112c237 commit 76d2029
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/phy/qualcomm/phy-qcom-qmp-combo.c
Original file line number Diff line number Diff line change
Expand Up @@ -2555,6 +2555,7 @@ static int qmp_combo_usb_power_on(struct phy *phy)
void __iomem *tx2 = qmp->tx2;
void __iomem *rx2 = qmp->rx2;
void __iomem *pcs = qmp->pcs;
void __iomem *pcs_usb = qmp->pcs_usb;
void __iomem *status;
unsigned int val;
int ret;
Expand All @@ -2576,6 +2577,9 @@ static int qmp_combo_usb_power_on(struct phy *phy)

qmp_combo_configure(pcs, cfg->pcs_tbl, cfg->pcs_tbl_num);

if (pcs_usb)
qmp_combo_configure(pcs_usb, cfg->pcs_usb_tbl, cfg->pcs_usb_tbl_num);

if (cfg->has_pwrdn_delay)
usleep_range(10, 20);

Expand Down

0 comments on commit 76d2029

Please sign in to comment.