Skip to content

Commit

Permalink
gpio: thunderx: fix error return code in thunderx_gpio_probe()
Browse files Browse the repository at this point in the history
Fix to return error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 5a2a300 ("gpio: Add gpio driver support for ThunderX and OCTEON-TX")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: David Daney <david.daney@cavium.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Wei Yongjun authored and Linus Walleij committed Jan 11, 2018
1 parent 92a8046 commit 76e28f5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/gpio/gpio-thunderx.c
Original file line number Diff line number Diff line change
Expand Up @@ -553,8 +553,10 @@ static int thunderx_gpio_probe(struct pci_dev *pdev,
txgpio->irqd = irq_domain_create_hierarchy(irq_get_irq_data(txgpio->msix_entries[0].vector)->domain,
0, 0, of_node_to_fwnode(dev->of_node),
&thunderx_gpio_irqd_ops, txgpio);
if (!txgpio->irqd)
if (!txgpio->irqd) {
err = -ENOMEM;
goto out;
}

/* Push on irq_data and the domain for each line. */
for (i = 0; i < ngpio; i++) {
Expand Down

0 comments on commit 76e28f5

Please sign in to comment.