Skip to content

Commit

Permalink
s390/sclp: disable early sclp code as soon as the base sclp driver is…
Browse files Browse the repository at this point in the history
… active

Make sure the early sclp code does not generate any sclp requests
anymore as soon as the base sclp driver is active. Otherwise both
drivers may see unexpected requests or may miss expected interrupts.

Reviewed-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Heiko Carstens authored and Martin Schwidefsky committed Feb 8, 2017
1 parent 9090f3f commit 76fdf14
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
7 changes: 0 additions & 7 deletions drivers/s390/char/sclp.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,6 @@ static struct timer_list sclp_request_timer;
/* Timer for queued requests. */
static struct timer_list sclp_queue_timer;

/* Internal state: is the driver initialized? */
static volatile enum sclp_init_state_t {
sclp_init_state_uninitialized,
sclp_init_state_initializing,
sclp_init_state_initialized
} sclp_init_state = sclp_init_state_uninitialized;

/* Internal state: is a request active at the sclp? */
static volatile enum sclp_running_state_t {
sclp_running_state_idle,
Expand Down
7 changes: 7 additions & 0 deletions drivers/s390/char/sclp.h
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,13 @@ int sclp_sync_request_timeout(sclp_cmdw_t command, void *sccb, int timeout);
int sclp_sdias_init(void);
void sclp_sdias_exit(void);

enum {
sclp_init_state_uninitialized,
sclp_init_state_initializing,
sclp_init_state_initialized
};

extern int sclp_init_state;
extern int sclp_console_pages;
extern int sclp_console_drop;
extern unsigned long sclp_console_full;
Expand Down
4 changes: 4 additions & 0 deletions drivers/s390/char/sclp_early_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ static char _sclp_work_area[4096] __aligned(PAGE_SIZE) __section(data);
static bool have_vt220 __section(data);
static bool have_linemode __section(data);

int sclp_init_state __section(data) = sclp_init_state_uninitialized;

static void _sclp_wait_int(void)
{
unsigned long psw_mask, addr, flags;
Expand Down Expand Up @@ -198,6 +200,8 @@ static void _sclp_print_vt220(const char *str, unsigned int len)
*/
void __sclp_print_early(const char *str, unsigned int len)
{
if (sclp_init_state != sclp_init_state_uninitialized)
return;
if (_sclp_setup(0) != 0)
return;
if (have_linemode)
Expand Down

0 comments on commit 76fdf14

Please sign in to comment.