Skip to content

Commit

Permalink
dpaa2-eth: Convert to DEFINE_SHOW_ATTRIBUTE
Browse files Browse the repository at this point in the history 
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Qinglang Miao authored and David S. Miller committed Sep 18, 2020
1 parent 2170ff0 commit 77646b6
Showing 1 changed file with 6 additions and 57 deletions.
63 changes: 6 additions & 57 deletions drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,24 +42,7 @@ static int dpaa2_dbg_cpu_show(struct seq_file *file, void *offset)
return 0;
}

static int dpaa2_dbg_cpu_open(struct inode *inode, struct file *file)
{
int err;
struct dpaa2_eth_priv *priv = (struct dpaa2_eth_priv *)inode->i_private;

err = single_open(file, dpaa2_dbg_cpu_show, priv);
if (err < 0)
netdev_err(priv->net_dev, "single_open() failed\n");

return err;
}

static const struct file_operations dpaa2_dbg_cpu_ops = {
.open = dpaa2_dbg_cpu_open,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
};
DEFINE_SHOW_ATTRIBUTE(dpaa2_dbg_cpu);

static char *fq_type_to_str(struct dpaa2_eth_fq *fq)
{
Expand Down Expand Up @@ -106,24 +89,7 @@ static int dpaa2_dbg_fqs_show(struct seq_file *file, void *offset)
return 0;
}

static int dpaa2_dbg_fqs_open(struct inode *inode, struct file *file)
{
int err;
struct dpaa2_eth_priv *priv = (struct dpaa2_eth_priv *)inode->i_private;

err = single_open(file, dpaa2_dbg_fqs_show, priv);
if (err < 0)
netdev_err(priv->net_dev, "single_open() failed\n");

return err;
}

static const struct file_operations dpaa2_dbg_fq_ops = {
.open = dpaa2_dbg_fqs_open,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
};
DEFINE_SHOW_ATTRIBUTE(dpaa2_dbg_fqs);

static int dpaa2_dbg_ch_show(struct seq_file *file, void *offset)
{
Expand Down Expand Up @@ -151,24 +117,7 @@ static int dpaa2_dbg_ch_show(struct seq_file *file, void *offset)
return 0;
}

static int dpaa2_dbg_ch_open(struct inode *inode, struct file *file)
{
int err;
struct dpaa2_eth_priv *priv = (struct dpaa2_eth_priv *)inode->i_private;

err = single_open(file, dpaa2_dbg_ch_show, priv);
if (err < 0)
netdev_err(priv->net_dev, "single_open() failed\n");

return err;
}

static const struct file_operations dpaa2_dbg_ch_ops = {
.open = dpaa2_dbg_ch_open,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
};
DEFINE_SHOW_ATTRIBUTE(dpaa2_dbg_ch);

void dpaa2_dbg_add(struct dpaa2_eth_priv *priv)
{
Expand All @@ -179,13 +128,13 @@ void dpaa2_dbg_add(struct dpaa2_eth_priv *priv)
priv->dbg.dir = dir;

/* per-cpu stats file */
debugfs_create_file("cpu_stats", 0444, dir, priv, &dpaa2_dbg_cpu_ops);
debugfs_create_file("cpu_stats", 0444, dir, priv, &dpaa2_dbg_cpu_fops);

/* per-fq stats file */
debugfs_create_file("fq_stats", 0444, dir, priv, &dpaa2_dbg_fq_ops);
debugfs_create_file("fq_stats", 0444, dir, priv, &dpaa2_dbg_fqs_fops);

/* per-fq stats file */
debugfs_create_file("ch_stats", 0444, dir, priv, &dpaa2_dbg_ch_ops);
debugfs_create_file("ch_stats", 0444, dir, priv, &dpaa2_dbg_ch_fops);
}

void dpaa2_dbg_remove(struct dpaa2_eth_priv *priv)
Expand Down

0 comments on commit 77646b6

Please sign in to comment.