Skip to content

Commit

Permalink
nfsd4: return "real" sequence id in confirmed case
Browse files Browse the repository at this point in the history
The client should ignore the returned sequence_id in the case where the
CONFIRMED flag is set on an exchange_id reply--and in the unconfirmed
case "1" is always the right response.  So it shouldn't actually matter
what we return here.

We could continue returning 1 just to catch clients ignoring the spec
here, but I'd rather be generous.  Other things equal, returning the
existing sequence_id seems more informative.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
J. Bruce Fields committed Jun 1, 2012
1 parent 0f1ba0e commit 778df3f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -1650,7 +1650,7 @@ nfsd4_exchange_id(struct svc_rqst *rqstp,
exid->clientid.cl_boot = new->cl_clientid.cl_boot;
exid->clientid.cl_id = new->cl_clientid.cl_id;

exid->seqid = 1;
exid->seqid = new->cl_cs_slot.sl_seqid + 1;
nfsd4_set_ex_flags(new, exid);

dprintk("nfsd4_exchange_id seqid %d flags %x\n",
Expand Down

0 comments on commit 778df3f

Please sign in to comment.