Skip to content

Commit

Permalink
PCI: spear: Remove spear13xx_pcie_remove()
Browse files Browse the repository at this point in the history
Following compilation warning occurs when compiled with:
CONFIG_DEBUG_SECTION_MISMATCH=y

 WARNING: vmlinux.o(.init.data+0x3338): Section mismatch in reference from the
 variable spear13xx_pcie_driver to the function
 .exit.text:spear13xx_pcie_remove()

This driver isn't allowed to unload, and so doesn't have a *_exit() routine. But
it still has spear13xx_pcie_remove() marked with __exit.

As this driver can't unload, .remove() would never be called, right? So get rid
of it.

Fixes: 51b66a6 (PCI: spear: Add PCIe driver for ST Microelectronics SPEAr13xx)
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Olof Johansson <olof@lixom.net>
  • Loading branch information
Viresh Kumar authored and Olof Johansson committed Jul 20, 2014
1 parent 6675ef2 commit 779ae55
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions drivers/pci/host/pcie-spear13xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -365,17 +365,6 @@ static int __init spear13xx_pcie_probe(struct platform_device *pdev)
return ret;
}

static int __exit spear13xx_pcie_remove(struct platform_device *pdev)
{
struct spear13xx_pcie *spear13xx_pcie = platform_get_drvdata(pdev);

clk_disable_unprepare(spear13xx_pcie->clk);

phy_exit(spear13xx_pcie->phy);

return 0;
}

static const struct of_device_id spear13xx_pcie_of_match[] = {
{ .compatible = "st,spear1340-pcie", },
{},
Expand All @@ -384,7 +373,6 @@ MODULE_DEVICE_TABLE(of, spear13xx_pcie_of_match);

static struct platform_driver spear13xx_pcie_driver __initdata = {
.probe = spear13xx_pcie_probe,
.remove = spear13xx_pcie_remove,
.driver = {
.name = "spear-pcie",
.owner = THIS_MODULE,
Expand Down

0 comments on commit 779ae55

Please sign in to comment.