Skip to content

Commit

Permalink
drm/bridge: ti-sn65dsi86: Allow GPIO operations to sleep
Browse files Browse the repository at this point in the history
There is no need to require non-sleeping GPIO access. Silence the
WARN_ON() if GPIO is using e.g. I2C expanders.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230405135127.769665-1-alexander.stein@ew.tq-group.com
  • Loading branch information
Alexander Stein authored and Douglas Anderson committed Apr 5, 2023
1 parent a80c882 commit 77d08a2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/bridge/ti-sn65dsi86.c
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ static int __maybe_unused ti_sn65dsi86_resume(struct device *dev)
/* td2: min 100 us after regulators before enabling the GPIO */
usleep_range(100, 110);

gpiod_set_value(pdata->enable_gpio, 1);
gpiod_set_value_cansleep(pdata->enable_gpio, 1);

/*
* If we have a reference clock we can enable communication w/ the
Expand All @@ -386,7 +386,7 @@ static int __maybe_unused ti_sn65dsi86_suspend(struct device *dev)
if (pdata->refclk)
ti_sn65dsi86_disable_comms(pdata);

gpiod_set_value(pdata->enable_gpio, 0);
gpiod_set_value_cansleep(pdata->enable_gpio, 0);

ret = regulator_bulk_disable(SN_REGULATOR_SUPPLY_NUM, pdata->supplies);
if (ret)
Expand Down

0 comments on commit 77d08a2

Please sign in to comment.