Skip to content

Commit

Permalink
hwspinlock: sirf: Change to use devm_platform_ioremap_resource()
Browse files Browse the repository at this point in the history
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together, which can simpify the code.

Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
Link: https://lore.kernel.org/r/dfa043f317c609a6172468ac11598968dd751bce.1578453662.git.baolin.wang7@gmail.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
  • Loading branch information
Baolin Wang authored and Bjorn Andersson committed Jan 22, 2020
1 parent 42f291e commit 77d99a6
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/hwspinlock/sirf_hwspinlock.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ static int sirf_hwspinlock_probe(struct platform_device *pdev)
return -ENOMEM;

/* retrieve io base */
hwspin->io_base = of_iomap(pdev->dev.of_node, 0);
if (!hwspin->io_base)
return -ENOMEM;
hwspin->io_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(hwspin->io_base))
return PTR_ERR(hwspin->io_base);

for (idx = 0; idx < HW_SPINLOCK_NUMBER; idx++) {
hwlock = &hwspin->bank.lock[idx];
Expand All @@ -92,7 +92,6 @@ static int sirf_hwspinlock_probe(struct platform_device *pdev)

reg_failed:
pm_runtime_disable(&pdev->dev);
iounmap(hwspin->io_base);

return ret;
}
Expand All @@ -110,8 +109,6 @@ static int sirf_hwspinlock_remove(struct platform_device *pdev)

pm_runtime_disable(&pdev->dev);

iounmap(hwspin->io_base);

return 0;
}

Expand Down

0 comments on commit 77d99a6

Please sign in to comment.