Skip to content

Commit

Permalink
misc: xilinx-sdfec: Drop unnecessary NULL check after container_of
Browse files Browse the repository at this point in the history
container_of() only returns NULL if the passed pointer is NULL _and_ if
the embedded element is the first element of the structure. Even if that
is the case, testing against it is misleading and possibly dangerous
because the position of the embedded element may change. In this case,
the check is unnecessary since it is known that file->private_data is
never NULL for an open file, and container_of() will therefore also
never be NULL. Drop the check.

Acked-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20210521200457.2112041-1-linux@roeck-us.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Guenter Roeck authored and Greg Kroah-Hartman committed May 21, 2021
1 parent b63866e commit 78429ed
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/misc/xilinx_sdfec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1013,9 +1013,6 @@ static __poll_t xsdfec_poll(struct file *file, poll_table *wait)

xsdfec = container_of(file->private_data, struct xsdfec_dev, miscdev);

if (!xsdfec)
return EPOLLNVAL | EPOLLHUP;

poll_wait(file, &xsdfec->waitq, wait);

/* XSDFEC ISR detected an error */
Expand Down

0 comments on commit 78429ed

Please sign in to comment.