Skip to content

Commit

Permalink
ima/policy: switch to use uuid_t
Browse files Browse the repository at this point in the history
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Acked-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  • Loading branch information
Christoph Hellwig committed Jun 5, 2017
1 parent 1dd771e commit 787d8c5
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions security/integrity/ima/ima_policy.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ struct ima_rule_entry {
enum ima_hooks func;
int mask;
unsigned long fsmagic;
u8 fsuuid[16];
uuid_t fsuuid;
kuid_t uid;
kuid_t fowner;
bool (*uid_op)(kuid_t, kuid_t); /* Handlers for operators */
Expand Down Expand Up @@ -244,7 +244,7 @@ static bool ima_match_rules(struct ima_rule_entry *rule, struct inode *inode,
&& rule->fsmagic != inode->i_sb->s_magic)
return false;
if ((rule->flags & IMA_FSUUID) &&
memcmp(rule->fsuuid, inode->i_sb->s_uuid, sizeof(rule->fsuuid)))
memcmp(&rule->fsuuid, inode->i_sb->s_uuid, sizeof(rule->fsuuid)))
return false;
if ((rule->flags & IMA_UID) && !rule->uid_op(cred->uid, rule->uid))
return false;
Expand Down Expand Up @@ -711,13 +711,12 @@ static int ima_parse_rule(char *rule, struct ima_rule_entry *entry)
case Opt_fsuuid:
ima_log_string(ab, "fsuuid", args[0].from);

if (memchr_inv(entry->fsuuid, 0x00,
sizeof(entry->fsuuid))) {
if (uuid_is_null(&entry->fsuuid)) {
result = -EINVAL;
break;
}

result = uuid_parse(args[0].from, (uuid_t *)&entry->fsuuid);
result = uuid_parse(args[0].from, &entry->fsuuid);
if (!result)
entry->flags |= IMA_FSUUID;
break;
Expand Down Expand Up @@ -1086,7 +1085,7 @@ int ima_policy_show(struct seq_file *m, void *v)
}

if (entry->flags & IMA_FSUUID) {
seq_printf(m, "fsuuid=%pU", entry->fsuuid);
seq_printf(m, "fsuuid=%pU", &entry->fsuuid);
seq_puts(m, " ");
}

Expand Down

0 comments on commit 787d8c5

Please sign in to comment.