Skip to content

Commit

Permalink
drivers/misc/sgi-xp: Adjust references in UV kernel modules
Browse files Browse the repository at this point in the history
Remove the define is_uv() is_uv_system and just use the latter as is.
This removes a conflict with a new symbol in the generated uv_mmrs.h
file (is_uv()).

Signed-off-by: Mike Travis <mike.travis@hpe.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Dimitri Sivanich <dimitri.sivanich@hpe.com>
Reviewed-by: Steve Wahl <steve.wahl@hpe.com>
Link: https://lkml.kernel.org/r/20201005203929.148656-4-mike.travis@hpe.com
  • Loading branch information
Mike Travis authored and Borislav Petkov committed Oct 7, 2020
1 parent c4d9807 commit 788b66e
Showing 6 changed files with 12 additions and 15 deletions.
7 changes: 1 addition & 6 deletions drivers/misc/sgi-xp/xp.h
Original file line number Diff line number Diff line change
@@ -17,11 +17,6 @@

#if defined CONFIG_X86_UV || defined CONFIG_IA64_SGI_UV
#include <asm/uv/uv.h>
#define is_uv() is_uv_system()
#endif

#ifndef is_uv
#define is_uv() 0
#endif

#ifdef USE_DBUG_ON
@@ -79,7 +74,7 @@

#define XPC_MSG_SIZE(_payload_size) \
ALIGN(XPC_MSG_HDR_MAX_SIZE + (_payload_size), \
is_uv() ? 64 : 128)
is_uv_system() ? 64 : 128)


/*
4 changes: 2 additions & 2 deletions drivers/misc/sgi-xp/xp_main.c
Original file line number Diff line number Diff line change
@@ -233,7 +233,7 @@ xp_init(void)
for (ch_number = 0; ch_number < XPC_MAX_NCHANNELS; ch_number++)
mutex_init(&xpc_registrations[ch_number].mutex);

if (is_uv())
if (is_uv_system())
ret = xp_init_uv();
else
ret = 0;
@@ -249,7 +249,7 @@ module_init(xp_init);
static void __exit
xp_exit(void)
{
if (is_uv())
if (is_uv_system())
xp_exit_uv();
}

6 changes: 4 additions & 2 deletions drivers/misc/sgi-xp/xp_uv.c
Original file line number Diff line number Diff line change
@@ -148,7 +148,9 @@ xp_restrict_memprotect_uv(unsigned long phys_addr, unsigned long size)
enum xp_retval
xp_init_uv(void)
{
BUG_ON(!is_uv());
WARN_ON(!is_uv_system());
if (!is_uv_system())
return xpUnsupported;

xp_max_npartitions = XP_MAX_NPARTITIONS_UV;
#ifdef CONFIG_X86
@@ -168,5 +170,5 @@ xp_init_uv(void)
void
xp_exit_uv(void)
{
BUG_ON(!is_uv());
WARN_ON(!is_uv_system());
}
6 changes: 3 additions & 3 deletions drivers/misc/sgi-xp/xpc_main.c
Original file line number Diff line number Diff line change
@@ -1043,7 +1043,7 @@ xpc_do_exit(enum xp_retval reason)

xpc_teardown_partitions();

if (is_uv())
if (is_uv_system())
xpc_exit_uv();
}

@@ -1226,7 +1226,7 @@ xpc_init(void)
dev_set_name(xpc_part, "part");
dev_set_name(xpc_chan, "chan");

if (is_uv()) {
if (is_uv_system()) {
ret = xpc_init_uv();

} else {
@@ -1312,7 +1312,7 @@ xpc_init(void)

xpc_teardown_partitions();
out_1:
if (is_uv())
if (is_uv_system())
xpc_exit_uv();
return ret;
}
2 changes: 1 addition & 1 deletion drivers/misc/sgi-xp/xpc_partition.c
Original file line number Diff line number Diff line change
@@ -433,7 +433,7 @@ xpc_discovery(void)
*/
region_size = xp_region_size;

if (is_uv())
if (is_uv_system())
max_regions = 256;
else {
max_regions = 64;
2 changes: 1 addition & 1 deletion drivers/misc/sgi-xp/xpnet.c
Original file line number Diff line number Diff line change
@@ -515,7 +515,7 @@ xpnet_init(void)
{
int result;

if (!is_uv())
if (!is_uv_system())
return -ENODEV;

dev_info(xpnet, "registering network device %s\n", XPNET_DEVICE_NAME);

0 comments on commit 788b66e

Please sign in to comment.