Skip to content

Commit

Permalink
bareudp: Use pcpu stats to update rx_dropped counter.
Browse files Browse the repository at this point in the history
Use the core_stats rx_dropped counter to avoid the cost of atomic
increments.

Signed-off-by: Guillaume Nault <gnault@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Guillaume Nault authored and David S. Miller committed Oct 28, 2024
1 parent 03fc07a commit 788d5d6
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/net/bareudp.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ static int bareudp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)

if (skb_copy_bits(skb, BAREUDP_BASE_HLEN, &ipversion,
sizeof(ipversion))) {
DEV_STATS_INC(bareudp->dev, rx_dropped);
dev_core_stats_rx_dropped_inc(bareudp->dev);
goto drop;
}
ipversion >>= 4;
Expand All @@ -94,7 +94,7 @@ static int bareudp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
} else if (ipversion == 6 && bareudp->multi_proto_mode) {
proto = htons(ETH_P_IPV6);
} else {
DEV_STATS_INC(bareudp->dev, rx_dropped);
dev_core_stats_rx_dropped_inc(bareudp->dev);
goto drop;
}
} else if (bareudp->ethertype == htons(ETH_P_MPLS_UC)) {
Expand All @@ -108,7 +108,7 @@ static int bareudp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
ipv4_is_multicast(tunnel_hdr->daddr)) {
proto = htons(ETH_P_MPLS_MC);
} else {
DEV_STATS_INC(bareudp->dev, rx_dropped);
dev_core_stats_rx_dropped_inc(bareudp->dev);
goto drop;
}
} else {
Expand All @@ -124,7 +124,7 @@ static int bareudp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
(addr_type & IPV6_ADDR_MULTICAST)) {
proto = htons(ETH_P_MPLS_MC);
} else {
DEV_STATS_INC(bareudp->dev, rx_dropped);
dev_core_stats_rx_dropped_inc(bareudp->dev);
goto drop;
}
}
Expand All @@ -136,15 +136,15 @@ static int bareudp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
proto,
!net_eq(bareudp->net,
dev_net(bareudp->dev)))) {
DEV_STATS_INC(bareudp->dev, rx_dropped);
dev_core_stats_rx_dropped_inc(bareudp->dev);
goto drop;
}

__set_bit(IP_TUNNEL_KEY_BIT, key);

tun_dst = udp_tun_rx_dst(skb, family, key, 0, 0);
if (!tun_dst) {
DEV_STATS_INC(bareudp->dev, rx_dropped);
dev_core_stats_rx_dropped_inc(bareudp->dev);
goto drop;
}
skb_dst_set(skb, &tun_dst->dst);
Expand Down

0 comments on commit 788d5d6

Please sign in to comment.