Skip to content

Commit

Permalink
irqchip/renesas-rzg2l: Use devm_reset_control_get_exclusive_deasserted()
Browse files Browse the repository at this point in the history
Use devm_reset_control_get_exclusive_deasserted() to simplify
rzg2l_irqc_common_init().

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/all/20250212182034.366167-3-fabrizio.castro.jz@renesas.com
  • Loading branch information
Fabrizio Castro authored and Thomas Gleixner committed Feb 18, 2025
1 parent dd4e17c commit 78f384d
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions drivers/irqchip/irq-renesas-rzg2l.c
Original file line number Diff line number Diff line change
Expand Up @@ -562,14 +562,10 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
return ret;
}

resetn = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(resetn))
resetn = devm_reset_control_get_exclusive_deasserted(dev, NULL);
if (IS_ERR(resetn)) {
dev_err(dev, "failed to acquire deasserted reset: %d\n", ret);
return PTR_ERR(resetn);

ret = reset_control_deassert(resetn);
if (ret) {
dev_err(dev, "failed to deassert resetn pin, %d\n", ret);
return ret;
}

pm_runtime_enable(dev);
Expand Down Expand Up @@ -609,7 +605,6 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
pm_runtime_put(dev);
pm_disable:
pm_runtime_disable(dev);
reset_control_assert(resetn);
return ret;
}

Expand Down

0 comments on commit 78f384d

Please sign in to comment.