Skip to content

Commit

Permalink
udf: fix udf_load_pvoldesc()
Browse files Browse the repository at this point in the history
There are some missing braces here which means this function never
succeeds.

Fixes: e9d4cf4 ('udf: improve error management in udf_CS0toUTF8()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jan Kara <jack@suse.cz>
  • Loading branch information
Dan Carpenter authored and Jan Kara committed May 21, 2015
1 parent 942d702 commit 792352c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion fs/udf/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -937,12 +937,13 @@ static int udf_load_pvoldesc(struct super_block *sb, sector_t block)
udf_debug("volIdent[] = '%s'\n", UDF_SB(sb)->s_volume_ident);
}

if (!udf_build_ustr(instr, pvoldesc->volSetIdent, 128))
if (!udf_build_ustr(instr, pvoldesc->volSetIdent, 128)) {
ret = udf_CS0toUTF8(outstr, instr);
if (ret < 0)
goto out_bh;

udf_debug("volSetIdent[] = '%s'\n", outstr->u_name);
}

ret = 0;
out_bh:
Expand Down

0 comments on commit 792352c

Please sign in to comment.