Skip to content

Commit

Permalink
drm/vmwgfx: limit the number of mip levels in vmw_gb_surface_define_i…
Browse files Browse the repository at this point in the history
…octl()

commit ee9c4e6 upstream.

The 'req->mip_levels' parameter in vmw_gb_surface_define_ioctl() is
a user-controlled 'uint32_t' value which is used as a loop count limit.
This can lead to a kernel lockup and DoS. Add check for 'req->mip_levels'.

References:
https://bugzilla.redhat.com/show_bug.cgi?id=1437431

Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
  • Loading branch information
Vladis Dronov authored and Ben Hutchings committed Jul 2, 2017
1 parent 702f4dd commit 7943d19
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
Original file line number Diff line number Diff line change
Expand Up @@ -1251,6 +1251,9 @@ int vmw_gb_surface_define_ioctl(struct drm_device *dev, void *data,
const struct svga3d_surface_desc *desc;
uint32_t backup_handle;

if (req->mip_levels > DRM_VMW_MAX_MIP_LEVELS)
return -EINVAL;

if (unlikely(vmw_user_surface_size == 0))
vmw_user_surface_size = ttm_round_pot(sizeof(*user_srf)) +
128;
Expand Down

0 comments on commit 7943d19

Please sign in to comment.