Skip to content

Commit

Permalink
nfsd4: make set of large acl return efbig, not resource
Browse files Browse the repository at this point in the history
If a client attempts to set an excessively large ACL, return
NFS4ERR_FBIG instead of NFS4ERR_RESOURCE.  I'm not sure FBIG is correct,
but I'm positive RESOURCE is wrong (it isn't even a well-defined error
any more for NFS versions since 4.1).

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
J. Bruce Fields committed Mar 27, 2014
1 parent 4c69d58 commit 798df33
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/nfsd/nfs4xdr.c
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ nfsd4_decode_fattr(struct nfsd4_compoundargs *argp, u32 *bmval,
READ32(nace);

if (nace > NFS4_ACL_MAX)
return nfserr_resource;
return nfserr_fbig;

*acl = nfs4_acl_new(nace);
if (*acl == NULL)
Expand Down

0 comments on commit 798df33

Please sign in to comment.