Skip to content

Commit

Permalink
bcma: use (get|put)_device when probing/removing device driver
Browse files Browse the repository at this point in the history
commit a971df0 upstream.

This allows tracking device state and e.g. makes devm work as expected.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Rafał Miłecki authored and Greg Kroah-Hartman committed Mar 12, 2017
1 parent 5a1f03f commit 79a7ff1
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/bcma/main.c
Original file line number Diff line number Diff line change
@@ -640,8 +640,11 @@ static int bcma_device_probe(struct device *dev)
drv);
int err = 0;

get_device(dev);
if (adrv->probe)
err = adrv->probe(core);
if (err)
put_device(dev);

return err;
}
@@ -654,6 +657,7 @@ static int bcma_device_remove(struct device *dev)

if (adrv->remove)
adrv->remove(core);
put_device(dev);

return 0;
}

0 comments on commit 79a7ff1

Please sign in to comment.