Skip to content

Commit

Permalink
82xx: FCC: Fixing a bug causing to FCC port lock-up
Browse files Browse the repository at this point in the history
The patch fixes FCC port lock-up, which occurs as a result of a bug
during underrun/collision handling. Within the tx_startup() function
in mac-fcc.c, the address of last BD is not calculated correctly.
As a result of wrong calculation of the last BD address, the next
transmitted BD may be set to an area out of the transmit BD ring.
This actually causes to port lock-up and it is not recoverable.

Signed-off-by: Martin Roth <martin.roth@motorolasolutions.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Martin Roth authored and David S. Miller committed Dec 16, 2015
1 parent 7bff47d commit 79aa05a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/freescale/fs_enet/mac-fcc.c
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ static void tx_restart(struct net_device *dev)
cbd_t __iomem *prev_bd;
cbd_t __iomem *last_tx_bd;

last_tx_bd = fep->tx_bd_base + (fpi->tx_ring * sizeof(cbd_t));
last_tx_bd = fep->tx_bd_base + ((fpi->tx_ring - 1) * sizeof(cbd_t));

/* get the current bd held in TBPTR and scan back from this point */
recheck_bd = curr_tbptr = (cbd_t __iomem *)
Expand Down

0 comments on commit 79aa05a

Please sign in to comment.