Skip to content

Commit

Permalink
ASoC: mediatek: mt8188: avoid uninitialized variable use
Browse files Browse the repository at this point in the history
The 'msk' variable has no initialization:

sound/soc/mediatek/mt8188/mt8188-dai-dmic.c:311:4: error: variable 'msk' is uninitialized when used here [-Werror,-Wuninitialized]
  311 |                         msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);
      |                         ^~~

Set it to zero before the loop.

Fixes: c1e42ec ("ASoC: mediatek: mt8188: Add support for DMIC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Link: https://patch.msgid.link/20250227131939.1040168-1-arnd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Arnd Bergmann authored and Mark Brown committed Feb 27, 2025
1 parent a54a659 commit 79ed408
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions sound/soc/mediatek/mt8188/mt8188-dai-dmic.c
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ static int mtk_dmic_event(struct snd_soc_dapm_widget *w,
switch (event) {
case SND_SOC_DAPM_PRE_PMU:
/* request fifo soft rst */
msk = 0;
for (i = dmic_num; i >= DMIC0; i--)
msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);

Expand Down

0 comments on commit 79ed408

Please sign in to comment.